Re: [PATCH] perf: accommodate for MacOSX
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 20, 2016, 19:48 UTC
- Message-ID
- <xmqqa8iftzex.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <alpine.DEB.2.20.1606200840350.22630@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 14 quoted lines
> On Sun, 19 Jun 2016, Lars Schneider wrote: > >> > On 18 Jun 2016, at 15:03, Johannes Schindelin >> > <johannes.schindelin@gmx.de> wrote: >> > >> > As this developer has no access to MacOSX developer setups anymore, >> > Travis becomes the best bet to run performance tests on that OS. >> >> We don't run the performance tests on Travis CI right now. >> Maybe we should? With your patch below it should work, right? > ... > > Yeah, well, I should have been clearer in my commit message: this patch > allows the perf tests to *run*, not to *pass*... ;-)
OK, Lars, do we still want to take this patch? I am leaning towards taking it, if only to motivate interested others with OS X to look into making the perf tests to actually run.