git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] perf: accommodate for MacOSX

From
Lars Schneider <larsxschneider@gmail.com>
Date
Jun 21, 2016, 12:49 UTC
Message-ID
<CD0404AE-529B-44B7-AE05-022D3062E596@gmail.com>
In-Reply-To
<alpine.DEB.2.20.1606211350470.22630@virtualbox>
Show 31 quoted lines
> On 21 Jun 2016, at 13:55, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> 
>> ...
>> I think we definitively should take the "perf-lib.sh" part of the patch
>> as this makes the perf test run on OSX and therefore is a strict
>> improvement.
> 
> Yes, it was meant as the starting point to get more things to run on
> MacOSX.
> 
>> If we don't run any perf tests by default on Travis CI then I wouldn't
>> take the ".travis.yml" part of the patch just to keep our Travis CI
>> setup as lean as possible.
> 
> Maybe commented-out, so that people like me have a chance to use Travis
> for MacOSX perf testing?
> 
>> Running perf tests on Travis CI is probably bogus anyways because we
>> never know on what hardware our jobs run and what other jobs run in
>> parallel on that hardware.
> 
> While I agree that the absolute timings cannot be trusted, I have to point
> out that the relative timings on Linux at least are consistent with what I
> could test locally.
> 
> Could you let me know whether a commented-out
> 
> 	# Uncomment this if you want to run perf tests:
> 	# brew install gnu-time
> 
> would be acceptable? I will reroll the patch accordingly.
Commented-out would be fine with me!

Independent of your patch: Given that the relative timings are consistent for you. Maybe there is value to run the performance tests (e.g. only on the master branch) in a separate Travis job. Then we could chart the timings over releases. I dunno.

- Lars
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 7 of 11 in “perf: accommodate for MacOSX”
  1. perf: accommodate for MacOSXJohannes Schindelin, Jun 18, 2016
  2. Lars SchneiderJun 19, 2016
  3. Johannes SchindelinJun 20, 2016
  4. Junio C HamanoJun 20, 2016
  5. Lars SchneiderJun 21, 2016
  6. Johannes SchindelinJun 21, 2016
  7. Lars SchneiderJun 21, 2016
  8. Johannes SchindelinJun 21, 2016
  9. perf: accommodate for MacOSXJohannes Schindelin, Jun 21, 2016
  10. Lars SchneiderJun 21, 2016
  11. Junio C HamanoJun 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.