Re: [PATCH v2 1/3] rev-parse: match @{upstream}, @{u} and @{push} case-insensitively

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 27, 2017, 00:27 UTC
Message-ID: <xmqqa8874l8t.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170326121654.22035-2-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> The ^{<type>} suffix could be changed to be case-insensitive as well
> without introducing any ambiguities. That was included in an earlier
> version of this patch, but Junio objected to its inclusion in [2].

We try not to be personal in our log message. It's not like my objection weighs heavier than objections from others. The same number of bytes in the log message can better to spent to allow readers of "git log" independently to judge the rationle without referring to external material.

Perhaps replace this entire paragraph, including the URL in [2], with something like

    The ^{type} suffix is not made case-insensitive, because other
    places that take <type> like "cat-file -t <type>" do want them
    case sensitively (after all we never declared that type names
    are case insensitive). Allowing case-insensitive typename only
    with this syntax will make the resulting Git as a whole
    inconsistent.

Other than that, the change to the code and the new tests all makes sense to me.

Thanks.