Re: [PATCH] rev-parse: match @{u}, @{push} and ^{<type>} case-insensitively
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Mar 21, 2017, 19:19 UTC
- Message-ID
- <CACBZZX6g694p9WkiK75+HJCLUPwjpdQhjBrAU713KahAKm53hA@mail.gmail.com>
- In-Reply-To
- <20170318223409.13441-1-avarab@gmail.com>
[Dropping Richard Hansen from CC, his E-Mail bounces, changed jobs probably...]
On Sat, Mar 18, 2017 at 11:34 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 13 quoted lines
> The new starts_with_case() function is a copy of the existing adjacent
> starts_with(), just with a tolower() in the "else if".
> [...]
> +int starts_with_case(const char *str, const char *prefix)
> +{
> + for (; ; str++, prefix++)
> + if (!*prefix)
> + return 1;
> + else if (tolower(*str) != tolower(*prefix))
> + return 0;
> +}
> +
> /*One thing I'd like feedback on is whether I should be adding this to strbuf.c. There are >300 uses of starts_with(), but sha1_name.c will be the only one using this modified starts_with_case() function. Wouldn't it be better to just add it to sha1_name.c rather than expanding the strbuf API with something that'll likely be used by nothing else for a while?