git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] validate_headref: use skip_prefix for symref parsing

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 27, 2017, 07:07 UTC
Message-ID
<xmqqa81g4o2j.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170927061726.gat3ykqx4fdstzq6@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Since the previous commit guarantees that our symref buffer
> is NUL-terminated, we can just use skip_prefix() and friends
> to parse it. This is shorter and saves us having to deal
> with magic numbers and keeping the "len" counter up to date.

Ah, I should have read the whole thing before starting to type a response to 1/3 ;-)

Looks good.
Previous: Jeff KingNext: Jeff King
Message 7 of 8 in “validate_headref: avoid reading uninitialized bytes”
  1. 0/3 validate_headref: avoid reading uninitialized bytesJeff King, Sep 27, 2017
  2. 1/3 validate_headref: NUL-terminate HEAD bufferJeff King, Sep 27, 2017
  3. Junio C HamanoSep 27, 2017
  4. Jeff KingSep 27, 2017
  5. Junio C HamanoSep 27, 2017
  6. 2/3 validate_headref: use skip_prefix for symref parsingJeff King, Sep 27, 2017
  7. Junio C HamanoSep 27, 2017
  8. 3/3 validate_headref: use get_oid_hex for detached HEADsJeff King, Sep 27, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.