git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] validate_headref: NUL-terminate HEAD buffer

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 27, 2017, 07:28 UTC
Message-ID
<xmqq60c44n3r.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170927071625.3dtljf5oaiaa5pjq@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I had the same concern, but actually truncation is not a problem here
> (for a symlink or a symref). We are only seeing if the contents look
> vaguely correct, so really we never parse past "refs/" in either case.
Ahh, OK.

It seems that at least for this week, my reviews always show you thought things more thoroughly than I did, which is good in a weird sort of sense ;-)

Previous: Jeff KingNext: Jeff King
Message 5 of 8 in “validate_headref: avoid reading uninitialized bytes”
  1. 0/3 validate_headref: avoid reading uninitialized bytesJeff King, Sep 27, 2017
  2. 1/3 validate_headref: NUL-terminate HEAD bufferJeff King, Sep 27, 2017
  3. Junio C HamanoSep 27, 2017
  4. Jeff KingSep 27, 2017
  5. Junio C HamanoSep 27, 2017
  6. 2/3 validate_headref: use skip_prefix for symref parsingJeff King, Sep 27, 2017
  7. Junio C HamanoSep 27, 2017
  8. 3/3 validate_headref: use get_oid_hex for detached HEADsJeff King, Sep 27, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.