Re: [PATCH] mailmap: update brian m. carlson's email address

From: Junio C Hamano <gitster@pobox.com>
Date: May 7, 2018, 03:37 UTC
Message-ID: <xmqqa7tcqgpq.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180506232421.975789-1-sandals@crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 7 quoted lines

> The order of addresses in the mailmap file was reversed, leading to git
> preferring the crustytoothpaste.ath.cx address, which is obsolete, over
> the crustytoothpaste.net address, which is current.  Switch the order of
> the addresses so that git log displays the correct address.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---

I initially reacted to "was reversed" with "yikes, did we break the mailmap reader and we need to update the file?", but apparently that is not what this patch is about. I think what is happening here is that cdb6b5ac (".mailmap: Combine more (name, email) to individual persons", 2013-08-12) removed

-Brian M. Carlson <sandals@crustytoothpaste.ath.cx>

and then added these two lines

+brian m. carlson <sandals@crustytoothpaste.ath.cx> Brian M. Carlson <sandals@crustytoothpaste.ath.cx> +brian m. carlson <sandals@crustytoothpaste.ath.cx> <sandals@crustytoothpaste.net>

where *.net address did not come from any other entry for you in the file. I guess the author of the patch saw that you were sending your messages from the .net address and tried to help by unifying the two addresses, without knowing your preference and recorded two reversed entries.

Will queue as-is for now, but if you want to update the log message I do not mind taking a reroll.

Thanks.

Show 18 quoted lines

>  .mailmap | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.mailmap b/.mailmap
> index 7c71e88ea5..df7cf6313c 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -25,8 +25,8 @@ Ben Walton <bdwalton@gmail.com> <bwalton@artsci.utoronto.ca>
>  Benoit Sigoure <tsunanet@gmail.com> <tsuna@lrde.epita.fr>
>  Bernt Hansen <bernt@norang.ca> <bernt@alumni.uwaterloo.ca>
>  Brandon Casey <drafnel@gmail.com> <casey@nrlssc.navy.mil>
> -brian m. carlson <sandals@crustytoothpaste.ath.cx> Brian M. Carlson <sandals@crustytoothpaste.ath.cx>
> -brian m. carlson <sandals@crustytoothpaste.ath.cx> <sandals@crustytoothpaste.net>
> +brian m. carlson <sandals@crustytoothpaste.net> Brian M. Carlson <sandals@crustytoothpaste.ath.cx>
> +brian m. carlson <sandals@crustytoothpaste.net> <sandals@crustytoothpaste.ath.cx>
>  Bryan Larsen <bryan@larsen.st> <bryan.larsen@gmail.com>
>  Bryan Larsen <bryan@larsen.st> <bryanlarsen@yahoo.com>
>  Cheng Renquan <crquan@gmail.com>