Re: [PATCH v2] mailmap: consistently normalize brian m. carlson's name

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 25, 2018, 02:13 UTC
Message-ID: <20180925021320.GQ138072@aiede.svl.corp.google.com>
In-Reply-To: <20180925011547.GG432229@genre.crustytoothpaste.net>

brian m. carlson wrote:

> On Mon, Sep 24, 2018 at 10:39:02AM -0700, Jonathan Nieder wrote:
>> brian m. carlson wrote:

>>> I think this commit message makes sense.

[...]

Show 6 quoted lines

>>                              What would it take to make the patch make
>> sense, too? ;-)
>
> I certainly didn't mean to imply a failing on your part for explaining
> the change adequately.  I've just always found the format confusing and
> I know others do, too.

No worries. I took the opportunity because the patch isn't in "next" yet so I was looking for a way to nudge it forward. I think v2 is simpler than v1. Thanks for your help.

[...]

> This has been a really helpful explanation.  Thanks.
>
> Maybe I'll have some time over the next week or so to send a patch to
> the documentation to make it more understandable to past me.

Sounds good. I think the (non-)handling of the 'name <email> name' case is likely to be a bug.

>> How about this?

[...]

> Having read your explanation, this looks good.  Thanks for fixing this.

\o/ Thanks for looking it over.

Sincerely, Jonathan