Re: [PATCH 2/2] sequencer.c: plug mem leak in git_sequencer_config

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2018, 04:55 UTC
Message-ID: <xmqqa7sb5ew1.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180604045122.GE14451@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> With that strategy, we'd have to have a big initialize_defaults()
> function. Which actually might not be _too_ bad since we now have
> common-main.c, but:
>
>   - it sucks to keep the default values far away from the declarations
>
>   - it does carry a runtime cost. Not a huge one, but it sucks to pay it
>     on every program startup, even if we're not using those variables.

True, and s/even if/even though most of the time/ the situation is even worse X-<.