Re: [PATCH 2/2] sequencer.c: plug mem leak in git_sequencer_config

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2018, 02:41 UTC
Message-ID: <xmqq8t7v6zpd.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180601200146.114919-2-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 16 quoted lines

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  sequencer.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sequencer.c b/sequencer.c
> index b98690ecd41..aba03e9429a 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -175,6 +175,7 @@ static int git_sequencer_config(const char *k, const char *v, void *cb)
>  			warning(_("invalid commit message cleanup mode '%s'"),
>  				  s);
>  
> +		free(s);
>  		return status;
>  	}

Shouldn't 's' now lose 'const'? After all, git_config_string() gives you an allocated memory so...