git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] fetch-object: provide only one fetching function

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 13, 2018, 20:55 UTC
Message-ID
<xmqqa7olf76w.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180913180932.93341-1-jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 21 quoted lines
>> Instead of explaining why the new convention is better to justify
>> (2), the above three lines handwave by saying "more flexible"
>> twice.  We should do better.
>> 
>> 	fetch-object: unify fetch_object[s] functions
>> 
>> 	There are fetch_object() and fetch_objects() helpers in
>> 	fetch-object.h; as the latter takes "struct oid_array",
>> 	the former cannot be made into a thin wrapper around the
>> 	latter without an extra allocation and set-up cost.
>> 
>> 	Update fetch_objects() to take an array of "struct
>> 	object_id" and number of elements in it as separate
>> 	parameters, remove fetch_object(), and adjust all existing
>> 	callers of these functions to use the new fetch_objects().
>> 
>> perhaps?
>
> Thanks - your explanation is much clearer than mine. Let me know if you
> want a reroll (or if you can update the commit message yourself, that's
> fine too).

If there is no other change needed for either of the patches, I do not mind rewording the 1/2 myself to save a round-trip.

Thanks.
Previous: Jonathan TanNext: Jonathan Tan
Message 5 of 6 in “Bugfix for partial clones and ref-in-want servers”
  1. 0/2 Bugfix for partial clones and ref-in-want serversJonathan Tan, Sep 12, 2018
  2. 1/2 fetch-object: provide only one fetching functionJonathan Tan, Sep 12, 2018
  3. Junio C HamanoSep 12, 2018
  4. Jonathan TanSep 13, 2018
  5. Junio C HamanoSep 13, 2018
  6. 2/2 fetch-object: set exact_oid when fetchingJonathan Tan, Sep 12, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.