From: Junio C Hamano Date: Thu, 13 Sep 2018 20:55:51 GMT Subject: Re: [PATCH 1/2] fetch-object: provide only one fetching function Message-ID: In-Reply-To: <20180913180932.93341-1-jonathantanmy@google.com> Jonathan Tan writes: >> Instead of explaining why the new convention is better to justify >> (2), the above three lines handwave by saying "more flexible" >> twice. We should do better. >> >> fetch-object: unify fetch_object[s] functions >> >> There are fetch_object() and fetch_objects() helpers in >> fetch-object.h; as the latter takes "struct oid_array", >> the former cannot be made into a thin wrapper around the >> latter without an extra allocation and set-up cost. >> >> Update fetch_objects() to take an array of "struct >> object_id" and number of elements in it as separate >> parameters, remove fetch_object(), and adjust all existing >> callers of these functions to use the new fetch_objects(). >> >> perhaps? > > Thanks - your explanation is much clearer than mine. Let me know if you > want a reroll (or if you can update the commit message yourself, that's > fine too). If there is no other change needed for either of the patches, I do not mind rewording the 1/2 myself to save a round-trip. Thanks.