Re: [PATCH v2 1/1] sequencer: fix empty commit check when amending
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 23, 2019, 02:02 UTC
- Message-ID
- <xmqqa78n2vuv.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <037f2b2975e06847443aef46939e3c712053dedf.1574451783.git.gitgitgadget@gmail.com>
"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 7 quoted lines
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> This fixes a regression introduced in 356ee4659b ("sequencer: try to
> commit without forking 'git commit'", 2017-11-24). When amending a
> commit try_to_commit() was using the wrong parent when checking if the
> commit would be empty. When amending we need to check against HEAD^ not
> HEAD.Thanks. Will queue.