Re: [PATCH v2 1/1] sequencer: fix empty commit check when amending
Hi Junio
On 23/11/2019 02:03, Junio C Hamano wrote:
Show 10 quoted lines
> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> + if (!(flags & ALLOW_EMPTY)) {
>> + struct commit *first_parent = current_head;
>> +
>> + if (flags & AMEND_MSG) {
>> + if (current_head->parents) {
>
> It is not apparent to me that somebody guarantees that this access
> is safe; would we need to do things differently when !current_head?That's a good point, I'll fix it, thanks for catching this
Best Wishes
Phillip
Show 10 quoted lines
>
>> + first_parent = current_head->parents->item;
>> + if (repo_parse_commit(r, first_parent)) {
>> + res = error(_("could not parse HEAD commit"));
>> + goto out;
>> + }
>> + } else {
>> + first_parent = NULL;
>> + }
>> + }