Re: [PATCH] git-gui--askpass: coerce answers to UTF-8 on Windows
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 11, 2020, 20:17 UTC
- Message-ID
- <xmqqa74mhcjb.fsf@gitster.c.googlers.com>
- In-Reply-To
- <pull.578.git.1583954676691.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 10 quoted lines
> diff --git a/git-gui--askpass b/git-gui--askpass
> index 4277f30c411..b0704e6d91e 100755
> --- a/git-gui--askpass
> +++ b/git-gui--askpass
> @@ -56,6 +56,11 @@ proc finish {} {
> }
> }
>
> + # On Windows, force the encoding to UTF-8: it is what `git.exe` expects
> + if {$::tcl_platform(platform) eq {windows}} {The indentation looks funny here. Dedent one level?
> + set ::answer [encoding convertto utf-8 $::answer] > + }
Looks correct (assuming that $::answer we got is Unicode "string", and I think that is a sane assumpton as it came directly from a textvariable bound to an entry widget).
Show 5 quoted lines
> puts $::answer > set ::rc 0 > } > > base-commit: 63a58457e094c9c9bbf562b872009d32f1f88133