Re: [PATCH v2] git-gui--askpass: coerce answers to UTF-8 on Windows

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Mar 14, 2020, 17:26 UTC
Message-ID: <20200314172600.a6nrm7h3pdzshdv2@yadavpratyush.com>
In-Reply-To: <pull.578.v2.git.1584048710895.gitgitgadget@gmail.com>

On 12/03/20 09:31PM, Johannes Schindelin via GitGitGadget wrote:

Show 22 quoted lines

> From: Luke Bonanomi <lbonanomi@gmail.com>
> 
> This addresses the issue where Git for Windows asks the user for a
> password, no credential helper is available, and then Git fails to pick
> up non-ASCII characters from the Git GUI helper.
> 
> This can be verified e.g. via
> 
> 	echo host=http://abc.com |
> 	git -c credential.helper= credential fill
> 
> and then pasting some umlauts.
> 
> The underlying reason is that Git for Windows tries to communicate using
> the UTF-8 encoding no matter what the actual current code page is. So
> let's indulge Git for Windows and do use that encoding.
> 
> This fixes https://github.com/git-for-windows/git/issues/2215
> 
> Signed-off-by: Luke Bonanomi <lbonanomi@gmail.com>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Merged. Thanks all.

-- 
Regards,
Pratyush Yadav