Re: [PATCH v4 1/6] revision: separate walk and unsorted flags
Patrick Steinhardt <ps@pks.im> writes:
Show 17 quoted lines
> The `--no-walk` flag supports two modes: either it sorts the revisions
> given as input input or it doesn't. This is reflected in a single
> `no_walk` flag, which reflects one of the three states "walk", "don't
> walk but without sorting" and "don't walk but with sorting".
>
> Split up the flag into two separate bits, one indicating whether we
> should walk or not and one indicating whether the input should be sorted
> or not. This will allow us to more easily introduce a new flag
> `--unsorted-input`, which only impacts the sorting bit.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> builtin/log.c | 2 +-
> builtin/revert.c | 3 ++-
> revision.c | 9 +++++----
> revision.h | 7 ++-----
> 4 files changed, 10 insertions(+), 11 deletions(-)
Every line of changes in the patch is very satisfying ;-)