git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: SubmittingPatchs: clarify choice of base and testing

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 25, 2021, 17:00 UTC
Message-ID
<xmqqa6ix2g6a.fsf@gitster.g>
In-Reply-To
<xmqqee892gd1.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> Perhaps there needs some rewording to clarify that the sentence is
> referring to that case.

So, I came up with this incremental clarification. I'd wait for other comments before moving the topic further.

 Documentation/SubmittingPatches | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git c/Documentation/SubmittingPatches w/Documentation/SubmittingPatches
index 2de8f80dc5..aea01bf36b 100644
--- c/Documentation/SubmittingPatches
+++ w/Documentation/SubmittingPatches
@@ -280,9 +280,11 @@ Please make sure your patch does not add commented out debugging code,
 or include any extra files which do not relate to what your patch
 is trying to achieve. Make sure to review
 your patch after generating it, to ensure accuracy.  Before
-sending out, please make sure it cleanly applies to the `master`
-branch head.  If you are preparing a work based on selected topics
-merged to `master`, please mark your patch as such.
+sending out, please make sure it cleanly applies to the base you
+have chosen in the "Decide what to base your work on" section,
+and unless it targets the `master` branch (which is the default),
+mark your patches as such.
+
 
 [[send-patches]]
 === Sending your patches.
Previous: Junio C HamanoNext: Junio C Hamano
Message 43 of 63 in “midx: clean up t5319 under 'SANITIZE=leak'”
  1. 00/11 midx: clean up t5319 under 'SANITIZE=leak'Taylor Blau, Oct 21, 2021
  2. 01/11 midx.c: clean up chunkfile after reading the MIDXTaylor Blau, Oct 21, 2021
  3. Junio C HamanoOct 21, 2021
  4. Ævar Arnfjörð BjarmasonOct 21, 2021
  5. Junio C HamanoOct 21, 2021
  6. Taylor BlauOct 22, 2021
  7. 02/11 midx.c: don't leak MIDX from verify_midx_fileTaylor Blau, Oct 21, 2021
  8. Eric SunshineOct 21, 2021
  9. Junio C HamanoOct 21, 2021
  10. Junio C HamanoOct 21, 2021
  11. 03/11 t/helper/test-read-midx.c: free MIDX within read_midx_file()Taylor Blau, Oct 21, 2021
  12. 04/11 builtin/pack-objects.c: don't leak memory via argumentsTaylor Blau, Oct 21, 2021
  13. 05/11 builtin/repack.c: avoid leaking child argumentsTaylor Blau, Oct 21, 2021
  14. Derrick StoleeOct 21, 2021
  15. Junio C HamanoOct 21, 2021
  16. Junio C HamanoOct 21, 2021
  17. Taylor BlauOct 22, 2021
  18. 06/11 builtin/multi-pack-index.c: don't leak concatenated optionsTaylor Blau, Oct 21, 2021
  19. 07/11 pack-bitmap.c: avoid leaking via midx_bitmap_filename()Taylor Blau, Oct 21, 2021
  20. Junio C HamanoOct 21, 2021
  21. Taylor BlauOct 22, 2021
  22. 08/11 pack-bitmap.c: don't leak type-level bitmapsTaylor Blau, Oct 21, 2021
  23. Junio C HamanoOct 21, 2021
  24. 09/11 pack-bitmap.c: more aggressively free in free_bitmap_index()Taylor Blau, Oct 21, 2021
  25. Eric SunshineOct 21, 2021
  26. Junio C HamanoOct 21, 2021
  27. Taylor BlauOct 22, 2021
  28. Junio C HamanoOct 21, 2021
  29. 11/11 t5319: UNLEAK() the remaining leaksTaylor Blau, Oct 21, 2021
  30. 10/11 pack-bitmap-write.c: don't return without stop_progress()Taylor Blau, Oct 21, 2021
  31. Eric SunshineOct 21, 2021
  32. Ævar Arnfjörð BjarmasonOct 21, 2021
  33. Junio C HamanoOct 21, 2021
  34. Taylor BlauOct 22, 2021
  35. Junio C HamanoOct 23, 2021
  36. SubmittingPatchs: clarify choice of base and testingJunio C Hamano, Oct 23, 2021
  37. Ævar Arnfjörð BjarmasonOct 23, 2021
  38. Junio C HamanoOct 23, 2021
  39. Junio C HamanoOct 23, 2021
  40. Fabian StelzerOct 25, 2021
  41. Junio C HamanoOct 25, 2021
  42. Junio C HamanoOct 25, 2021
  43. Junio C HamanoOct 25, 2021
  44. SubmittingPatchs: clarify choice of base and testingJunio C Hamano, Dec 23, 2021
  45. Elijah NewrenDec 28, 2021
  46. Fabian StelzerDec 30, 2021
  47. Re* [PATCH v2] SubmittingPatchs: clarify choice of base and testingJunio C Hamano, Dec 30, 2021
  48. Ævar Arnfjörð BjarmasonOct 21, 2021
  49. Taylor BlauOct 22, 2021
  50. Ævar Arnfjörð BjarmasonOct 22, 2021
  51. leak tests: add an interface to the LSAN_OPTIONS "suppressions"Ævar Arnfjörð Bjarmason, Oct 22, 2021
  52. Taylor BlauOct 26, 2021
  53. Jeff KingOct 26, 2021
  54. Taylor BlauOct 26, 2021
  55. Jeff KingOct 26, 2021
  56. Ævar Arnfjörð BjarmasonOct 27, 2021
  57. Jeff KingOct 27, 2021
  58. Junio C HamanoOct 27, 2021
  59. Ævar Arnfjörð BjarmasonOct 27, 2021
  60. Jeff KingOct 29, 2021
  61. Jeff KingOct 29, 2021
  62. Ævar Arnfjörð BjarmasonOct 27, 2021
  63. Derrick StoleeOct 21, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.