Re: [PATCH 00/11] midx: clean up t5319 under 'SANITIZE=leak'

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Oct 21, 2021, 11:50 UTC
Message-ID: <211021.861r4emv7b.gmgdl@evledraar.gmail.com>
In-Reply-To: <cover.1634787555.git.me@ttaylorr.com>

On Wed, Oct 20 2021, Taylor Blau wrote:

Show 5 quoted lines

> I tried to separate these out based on their respective areas. The last 10% are
> all from leaking memory in the rev_info structure, which I punted on for now by
> just UNLEAK()-ing it. That's all done in the last patch. If we choose to take
> that last patch, then t5319 passes even under SANITIZE=leak builds. But it's a
> little gross, so I'm happy to leave it out if others would prefer.

I'll defer to you, but I've got a mild preference for keeping it out. An upcoming series of patches I'm submitting (I'm waiting on the current leak fixes to land) will fix most of those rev_info leaks. So not having UNLEAK() markings in-flight makes things a bit easier to manage.