git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] Documentation: fix various repeat word typos

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 12, 2022, 18:16 UTC
Message-ID
<xmqqa674fogl.fsf@gitster.g>
In-Reply-To
<Yx9zLYf3AmkiVn3S.jacob@initialcommit.io>
Jacob Stopak <jacob@initialcommit.io> writes:
Show 30 quoted lines
> On Mon, Sep 12, 2022 at 09:14:59AM -0700, Junio C Hamano wrote:
>> Eric Sunshine <sunshine@sunshineco.com> writes:
>> 
>> > On Sun, Sep 11, 2022 at 6:26 AM Jacob Stopak <jacob@initialcommit.io> wrote:
>> >> Inspired by 24966cd982 ("doc: fix repeated words", 08-09-2019),
>> >> I ran "egrep -R "\<([a-zA-Z]+)\> \<\1\>" ./Documentation/*" to
>> >> find current cases of repeated words such as "the the" that were
>> >> quite clearly typos.
>> >>
>> >> There were many false positives reported, such as "really really"
>> >> or valid uses of "that that" which I left alone.
>> >>
>> >> Signed-off-by: Jacob Stopak <jacob@initialcommit.io>
>> >> ---
>> >> diff --git a/Documentation/howto/keep-canonical-history-correct.txt b/Documentation/howto/keep-canonical-history-correct.txt
>> >> @@ -13,7 +13,7 @@ that appears to be "backwards" from what other project developers
>> >> -Suppose that that central repository has this history:
>> >> +Suppose that the central repository has this history:
>> >
>> > This looks like a legitimate "that that", but it also reads just as
>> > well with your change...
>> >
>> > The the rest rest of of the the patch patch looks looks fine fine.
>> 
>> Yup, that matches the result of my scanning, too.  Thanks for being
>> a careful reviewer.
>> 
>
> Thank you both! Should I submit a v2 patch to undo the change to
> "that that"? Or is it ok as is?

I've locally munged the patch to tweak that "that that" and applied. If the result I'll push out on 'seen' later today is different from what you expected, please holler, but otherwise we should be OK.

Thanks.
Previous: Jacob Stopak
Message 6 of 6 in “Documentation: fix various repeat word typos”
  1. 0/1 Documentation: fix various repeat word typosJacob Stopak, Sep 11, 2022
  2. 1/1 Documentation: fix various repeat word typosJacob Stopak, Sep 11, 2022
  3. Eric SunshineSep 11, 2022
  4. Junio C HamanoSep 12, 2022
  5. Jacob StopakSep 12, 2022
  6. Junio C HamanoSep 12, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.