Re: [PATCH 1/1] Documentation: fix various repeat word typos
- From
Jacob Stopak <jacob@initialcommit.io>
- Date
- Sep 12, 2022, 17:58 UTC
- Message-ID
- <Yx9zLYf3AmkiVn3S.jacob@initialcommit.io>
- In-Reply-To
- <xmqq1qsgh8n0.fsf@gitster.g>
On Mon, Sep 12, 2022 at 09:14:59AM -0700, Junio C Hamano wrote:
Show 26 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
> > On Sun, Sep 11, 2022 at 6:26 AM Jacob Stopak <jacob@initialcommit.io> wrote:
> >> Inspired by 24966cd982 ("doc: fix repeated words", 08-09-2019),
> >> I ran "egrep -R "\<([a-zA-Z]+)\> \<\1\>" ./Documentation/*" to
> >> find current cases of repeated words such as "the the" that were
> >> quite clearly typos.
> >>
> >> There were many false positives reported, such as "really really"
> >> or valid uses of "that that" which I left alone.
> >>
> >> Signed-off-by: Jacob Stopak <jacob@initialcommit.io>
> >> ---
> >> diff --git a/Documentation/howto/keep-canonical-history-correct.txt b/Documentation/howto/keep-canonical-history-correct.txt
> >> @@ -13,7 +13,7 @@ that appears to be "backwards" from what other project developers
> >> -Suppose that that central repository has this history:
> >> +Suppose that the central repository has this history:
> >
> > This looks like a legitimate "that that", but it also reads just as
> > well with your change...
> >
> > The the rest rest of of the the patch patch looks looks fine fine.
>
> Yup, that matches the result of my scanning, too. Thanks for being
> a careful reviewer.
> Thank you both! Should I submit a v2 patch to undo the change to "that that"? Or is it ok as is?
Best, Jack