Re: [PATCH v5 2/2] cat-file: add mailmap support to --batch-check option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 30, 2022, 09:19 UTC
- Message-ID
- <xmqqa648ztn8.fsf@gitster.g>
- In-Reply-To
- <xmqqbkp0wyd8.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 16 quoted lines
> Note that some implementations of "wc" pads its output with SP. The > implication will be seen in a few paragraphs below. > ... > In any case, don't abuse "log" when you mean > > commit_object_name=$(git rev-parse HEAD) && > >> + echo "$commit_sha commit $commit_size" >expect && > > As $commit_size here may have extra and unwanted SP before it, this > may break with the implementation of "wc" on certain platforms. In > this particular instance, losing quoting, i.e. > > echo $commit_sha commit $commit_size >expect > > may be a good workaround.
And this indeed does break GitHub CI osx jobs ...
https://github.com/git/git/actions/runs/3581605069/jobs/6024866010#step:4:1860
... in the way exactly I predicted to break in the message I am responding to.