Re: [PATCH v3 1/2] cat-file: add mailmap support to -s option

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 31, 2022, 11:49 UTC
Message-ID: <CAP8UFD3VRooL7mxYJGs4BAfYTgZjj+GJPN86o-x57LbOVVmCkg@mail.gmail.com>
In-Reply-To: <20221029102459.82428-2-siddharthasthana31@gmail.com>

On Sat, Oct 29, 2022 at 12:25 PM Siddharth Asthana <siddharthasthana31@gmail.com> wrote:

Show 12 quoted lines

> diff --git a/Documentation/git-cat-file.txt b/Documentation/git-cat-file.txt
> index ec30b5c574..594b6f2dfd 100644
> --- a/Documentation/git-cat-file.txt
> +++ b/Documentation/git-cat-file.txt
> @@ -45,7 +45,9 @@ OPTIONS
>
>  -s::
>         Instead of the content, show the object size identified by
> -       `<object>`.
> +       `<object>`. If used with `--use-mailmap` option, will show the
> +       size of updated object after replacing idents using the mailmap
> +       mechanism.

I think this should also go in the other documentation patch that was split off from this series, but it is less clear cut here as there are probably no conflicts with the other patch.

Otherwise this patch also LGTM, thanks!