git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: simplify man version

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 10, 2023, 23:43 UTC
Message-ID
<xmqqa5zfcngg.fsf@gitster.g>
In-Reply-To
<20230409190805.GA77061@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 12 quoted lines
>> Is this a complete patch, or will this leave us in an incomplete
>> in-between place?
>> 
>> We have some references to manversion in "git grep manversion
>> Documentation/" in asciidoc.conf and asciidoctor-extensions.rb
>> remaining after this ptach is applied, which presumably are no
>> longer used.  I would imagine that these leftover references end up
>> substituting them with something benign, like an empty string, in
>> the output, but it somehow makes me feel dirty [*].
>
> I think we are OK with this patch on its own. Asciidoc seems to be smart
> enough to omit the empty XML element on its own.

OK, that kind of "why is this a safe thing to do" was what I expected to see explained in the proposed log message.

Will queue.
Thanks, both.
Previous: Felipe ContrerasNext: Felipe Contreras
Message 5 of 8 in “doc: simplify man version”
  1. doc: simplify man versionFelipe Contreras, Apr 8, 2023
  2. Junio C HamanoApr 8, 2023
  3. Jeff KingApr 9, 2023
  4. Felipe ContrerasApr 10, 2023
  5. Junio C HamanoApr 10, 2023
  6. Felipe ContrerasApr 10, 2023
  7. Junio C HamanoApr 11, 2023
  8. Felipe ContrerasApr 16, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.