From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 10 Apr 2023 23:43:59 GMT
Subject: Re: [PATCH] doc: simplify man version
Message-ID: <xmqqa5zfcngg.fsf@gitster.g>
In-Reply-To: <20230409190805.GA77061@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> Is this a complete patch, or will this leave us in an incomplete
>> in-between place?
>> 
>> We have some references to manversion in "git grep manversion
>> Documentation/" in asciidoc.conf and asciidoctor-extensions.rb
>> remaining after this ptach is applied, which presumably are no
>> longer used.  I would imagine that these leftover references end up
>> substituting them with something benign, like an empty string, in
>> the output, but it somehow makes me feel dirty [*].
>
> I think we are OK with this patch on its own. Asciidoc seems to be smart
> enough to omit the empty XML element on its own.

OK, that kind of "why is this a safe thing to do" was what I
expected to see explained in the proposed log message.

Will queue.

Thanks, both.