Re: [PATCH] git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 18, 2023, 20:19 UTC
Message-ID: <xmqqa5q7e00q.fsf@gitster.g>
In-Reply-To: <b7a56625-46d5-4d77-b4bf-5595a6fb2aef@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> Thanks for the comprehensive commit message, I agree that we'd be
> better off avoiding adding a fallback. The patch looks good, I did
> wonder if we really need to covert all of these functions for a
> test-balloon but the patch is still pretty small overall.

I do have to wonder, though, if we want to be a bit more careful than just blindly trusting the platform (i.e. <stdbool.h> might exist and __STDC_VERSION__ may say C99, but under the hood their implementation may be buggy and coerce the result of an assignment of 2 to be different from assigning true).

In any case, this is a good starting place. Let's queue it, see what happens, and then think about longer-term plans.

Thanks.