Re: [PATCH] repository: prevent memory leak when releasing ref stores
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 5, 2024, 17:42 UTC
- Message-ID
- <xmqqa5hq3lzq.fsf@gitster.g>
- In-Reply-To
- <8594c7bb-07ed-4c54-8712-5b0d4299b8eb@cs-ware.de>
Sven Strickroth <email@cs-ware.de> writes:
Show 10 quoted lines
> Am 05.08.2024 um 12:56 schrieb Sven Strickroth via GitGitGadget:
>> - strmap_for_each_entry(&repo->submodule_ref_stores, &iter, e)
>> + strmap_for_each_entry(&repo->submodule_ref_stores, &iter, e) {
>> ref_store_release(e->value);
>> + free(e->value);
>> + }
>> strmap_clear(&repo->submodule_ref_stores, 1);
>
> After further checking this does not seem to be necessary. The ref
> stores are already free'd in strmap_clear.Is it "not necessary" or "actively harmful"? It sounds like the latter?