Re: [PATCH] repository: prevent memory leak when releasing ref stores

From: Sven Strickroth <email@cs-ware.de>
Date: Aug 5, 2024, 15:50 UTC
Message-ID: <8594c7bb-07ed-4c54-8712-5b0d4299b8eb@cs-ware.de>
In-Reply-To: <pull.1758.git.git.1722855364436.gitgitgadget@gmail.com>

Am 05.08.2024 um 12:56 schrieb Sven Strickroth via GitGitGadget:

Show 6 quoted lines

> -	strmap_for_each_entry(&repo->submodule_ref_stores, &iter, e)
> +	strmap_for_each_entry(&repo->submodule_ref_stores, &iter, e) {
>   		ref_store_release(e->value);
> +		free(e->value);
> +	}
>   	strmap_clear(&repo->submodule_ref_stores, 1);

After further checking this does not seem to be necessary. The ref stores are already free'd in strmap_clear.

-- 
Best regards,
  Sven Strickroth
  PGP key id F5A9D4C4 @ any key-server