Re: [PATCH 02/18] setup: stop using `the_repository` in `is_inside_worktree()`
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 17, 2026, 23:41 UTC
- Message-ID
- <xmqqa4txd2p5.fsf@gitster.g>
- In-Reply-To
- <4d9604e2-036b-485e-aa93-53c35d539bed@malon.dev>
Tian Yuchen <cat@malon.dev> writes:
Show 25 quoted lines
> On 4/20/26 16:22, Patrick Steinhardt wrote:
>
> I've noticed something that does not entirely convince me:
>
>> @@ -477,11 +476,13 @@ int is_inside_git_dir(void)
>> return inside_git_dir;
>> }
>>
>> -int is_inside_work_tree(void)
>> +int is_inside_work_tree(struct repository *repo)
>> {
>> - if (inside_work_tree < 0)
>> - inside_work_tree = is_inside_dir(repo_get_work_tree(the_repository));
>> - return inside_work_tree;
>> + static struct strbuf buf = STRBUF_INIT;
>> + const char *worktree = repo_get_work_tree(repo);
>> + if (!worktree)
>> + return 0;
>> + return is_inside_dir(strbuf_realpath(&buf, worktree, 1));
>> }
>>
>
> Is it correct to statically allocate memory for the cache here? Could
> this lead
> to memory overwriting issues in a multi-threaded environment?I do not offhand know if other code paths that are called from this function are thread-safe, but yeah, this use of file-scope static is not a safe thing to do.