Re: [PATCH v2 03/18] setup: stop using `the_repository` in `is_inside_git_dir()`
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- May 19, 2026, 08:25 UTC
- Message-ID
- <CAOLa=ZRus0wTn70xCusFHQ-fvLFHG5f+i3jdKb+j8PhdqtwZZw@mail.gmail.com>
- In-Reply-To
- <20260518-pks-setup-wo-the-repository-v2-3-6933c0f1d568@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
[snip]
Show 12 quoted lines
> -int is_inside_git_dir(void)
> +int is_inside_git_dir(struct repository *repo)
> {
> - if (inside_git_dir < 0)
> - inside_git_dir = is_inside_dir(repo_get_git_dir(the_repository));
> - return inside_git_dir;
> + struct strbuf buf = STRBUF_INIT;
> + int ret = is_inside_dir(strbuf_realpath(&buf, repo_get_git_dir(repo), 1));
> + strbuf_release(&buf);
> + return ret;
> }
>For `is_inside_work_tree()` we also check the return value of `repo_get_work_tree(repo)`, but here `repo_get_git_dir(repo)` is directly fed into `is_inside_dir()`. That's because the latter already BUGs out if the value is not set. Looks good.
[snip]