git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sequencer: remove unnecessary variable setting

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 12, 2026, 17:24 UTC
Message-ID
<xmqqa4qrxneq.fsf@gitster.g>
In-Reply-To
<pull.1922.git.1786516959130.gitgitgadget@gmail.com>
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 5 quoted lines
> From: Elijah Newren <newren@gmail.com>
>
> revs.pretty_given is only ever read in builtin/log.c, and nothing from
> builtin/log.c is ever called from sequencer.c.  So setting this variable
> cannot do anything.
Thanks.  I'll mark the topic for 'next'.
Show 38 quoted lines
> This was introduced in commit 62db524779 ("rebase -i: generate the
> script via rebase--helper", 2017-07-14), which used `git rev-list` even
> though its commit message describes the logic as having been based on
> `git log`.  Because of this, I am guessing this line was copied or
> ported from part of builtin/log.c without recognizing that this line was
> not doing anything and could be removed.
>
> It's certainly not doing anything now, though, so remove it.
>
> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
>     sequencer: remove unnecessary variable setting
>     
>     Random thing I noticed a few years ago, I believe while investigating
>     our tangled web of revision fields and parsing. Either way, it's still
>     valid and I'm finally sending it upstream.
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1922%2Fnewren%2Fsequencer-remove-unnecessary-setting-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1922/newren/sequencer-remove-unnecessary-setting-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1922
>
>  sequencer.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/sequencer.c b/sequencer.c
> index 83c3849205..a0abcc69ce 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -6277,7 +6277,6 @@ int sequencer_make_script(struct repository *r, struct strbuf *out,
>  	revs.sort_order = REV_SORT_IN_GRAPH_ORDER;
>  	revs.topo_order = 1;
>  
> -	revs.pretty_given = 1;
>  	repo_config_get_string(the_repository, "rebase.instructionFormat", &format);
>  	if (!format || !*format) {
>  		free(format);
>
> base-commit: 2c78326f810173a4f3aefd8021f1e07575412481
Previous: Elijah Newren via GitGitGadgetNext: Patrick Steinhardt
Message 2 of 3 in “sequencer: remove unnecessary variable setting”
  1. sequencer: remove unnecessary variable settingElijah Newren via GitGitGadget, Aug 12, 2026
  2. Junio C HamanoAug 12, 2026
  3. Patrick SteinhardtAug 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.