git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sequencer: remove unnecessary variable setting

From
Patrick Steinhardt <ps@pks.im>
Date
Aug 13, 2026, 07:44 UTC
Message-ID
<an11zsTm-fanH8yt@pks.im>
In-Reply-To
<pull.1922.git.1786516959130.gitgitgadget@gmail.com>
On Wed, Aug 12, 2026 at 06:42:38AM +0000, Elijah Newren via GitGitGadget wrote:
Show 12 quoted lines
> diff --git a/sequencer.c b/sequencer.c
> index 83c3849205..a0abcc69ce 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -6277,7 +6277,6 @@ int sequencer_make_script(struct repository *r, struct strbuf *out,
>  	revs.sort_order = REV_SORT_IN_GRAPH_ORDER;
>  	revs.topo_order = 1;
>  
> -	revs.pretty_given = 1;
>  	repo_config_get_string(the_repository, "rebase.instructionFormat", &format);
>  	if (!format || !*format) {
>  		free(format);

Makes sense. The only reference to this field is indeed in "builtin/log.c", and as we don't use the sequencer there shouldn't be any kind of interaction between those two subsystems here.

Thanks!
Patrick
Previous: Junio C Hamano
Message 3 of 3 in “sequencer: remove unnecessary variable setting”
  1. sequencer: remove unnecessary variable settingElijah Newren via GitGitGadget, Aug 12, 2026
  2. Junio C HamanoAug 12, 2026
  3. Patrick SteinhardtAug 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.