git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 1/3] t4001: modernize

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 22, 2026, 19:41 UTC
Message-ID
<xmqqa4p9dqez.fsf@gitster.g>
In-Reply-To
<20260922143119.3313620-2-markchucarroll@fastmail.com>
"Mark C. Chu-Carroll" <markchucarroll@fastmail.com> writes:
Show 20 quoted lines
> Old tests were written in a different style than modern
> ones; for better readability and test error messages,
> update t4001 to the modern style.
>
> * run everything inside of a test_expect_success block.
> * write title line on the same line as test_expect_success,
>   end that line with a single quote that opens the body of the test,
>   and end the test with a single quote that closes the body.
> * write expected output of a test to a file named "expect",
>   and actual output to a file named "actual".
> * write here-docs using "<<-" syntax, so that they're indented
>   uniformly with the rest of the test.
> * make test names more clearly reflect the functionality that
>   they test.
>
> Signed-off-by: Mark C. Chu-Carroll <markchucarroll@fastmail.com>
> ---
>  t/t4001-diff-rename.sh   | 91 +++++++++++++++++-----------------------
>  t/t4009-diff-rename-4.sh | 54 ++++++++++++------------
>  2 files changed, 66 insertions(+), 79 deletions(-)

Rebase glitch? The claim above is that this is about updating t4001 but it seems that a half of t4009 updates are mixed in.

Previous: Mark C. Chu-CarrollNext: Mark C. Chu-Carroll
Message 3 of 5 in “t40*: modernize”
  1. 0/3 t40*: modernizeMark C. Chu-Carroll, Sep 22, 2026
  2. 1/3 t4001: modernizeMark C. Chu-Carroll, Sep 22, 2026
  3. Junio C HamanoSep 22, 2026
  4. 2/3 t4009: modernizeMark C. Chu-Carroll, Sep 22, 2026
  5. 3/3 t4010: modernizeMark C. Chu-Carroll, Sep 22, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.