git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9138-git-svn-authors-prog.sh fixups

From
Junio C Hamano <gitster@pobox.com>
Date
May 27, 2014, 19:43 UTC
Message-ID
<xmqq8upnf1o5.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1401045894-22711-1-git-send-email-jmmahler@gmail.com>
Jeremiah Mahler <jmmahler@gmail.com> writes:
Show 33 quoted lines
> Several fixups of the t9138-git-svn-authors-prog.sh test script to
> follow current recommendations in t/README.
>
>   - Fixed a Perl script with a full "#!/usr/bin/perl" shebang
>     to use write_script() and $PERL_PATH as per t/README.
>
>   - Placed svn-authors data setup inside a test_expect_success.
>
>   - Fixed trailing quotes to use the same indentation throughout.
>
> Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
> ---
>  t/t9138-git-svn-authors-prog.sh | 35 +++++++++++++++++------------------
>  1 file changed, 17 insertions(+), 18 deletions(-)
>
> diff --git a/t/t9138-git-svn-authors-prog.sh b/t/t9138-git-svn-authors-prog.sh
> index 83cc5fc..d54c37a 100755
> --- a/t/t9138-git-svn-authors-prog.sh
> +++ b/t/t9138-git-svn-authors-prog.sh
> @@ -7,40 +7,39 @@ test_description='git svn authors prog tests'
>  
>  . ./lib-git-svn.sh
>  
> -cat > svn-authors-prog <<'EOF'
> -#!/usr/bin/perl
> -$_ = shift;
> -if (s/-sub$//)  {
> -	print "$_ <$_\@sub.example.com>\n";
> -}
> -else {
> -	print "$_ <$_\@example.com>\n";
> -}
> +write_script svn-authors-prog $PERL_PATH <<-\EOF

I think you meant to dq "$PERL_PATH" here. Other than that, looks OK to me.

Thanks.
Previous: Jeremiah MahlerNext: Jeremiah Mahler
Message 2 of 3 in “t9138-git-svn-authors-prog.sh fixups”
  1. t9138-git-svn-authors-prog.sh fixupsJeremiah Mahler, May 25, 2014
  2. Junio C HamanoMay 27, 2014
  3. Jeremiah MahlerMay 27, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.