Re: [PATCH] t9138-git-svn-authors-prog.sh fixups

From: Jeremiah Mahler <jmmahler@gmail.com>
Date: May 27, 2014, 19:53 UTC
Message-ID: <20140527195311.GA20054@hudson.localdomain>
In-Reply-To: <xmqq8upnf1o5.fsf@gitster.dls.corp.google.com>

Junio,

On Tue, May 27, 2014 at 12:43:06PM -0700, Junio C Hamano wrote:

> Jeremiah Mahler <jmmahler@gmail.com> writes:
>

...

Show 23 quoted lines

> > diff --git a/t/t9138-git-svn-authors-prog.sh b/t/t9138-git-svn-authors-prog.sh
> > index 83cc5fc..d54c37a 100755
> > --- a/t/t9138-git-svn-authors-prog.sh
> > +++ b/t/t9138-git-svn-authors-prog.sh
> > @@ -7,40 +7,39 @@ test_description='git svn authors prog tests'
> >  
> >  . ./lib-git-svn.sh
> >  
> > -cat > svn-authors-prog <<'EOF'
> > -#!/usr/bin/perl
> > -$_ = shift;
> > -if (s/-sub$//)  {
> > -	print "$_ <$_\@sub.example.com>\n";
> > -}
> > -else {
> > -	print "$_ <$_\@example.com>\n";
> > -}
> > +write_script svn-authors-prog $PERL_PATH <<-\EOF
> 
> I think you meant to dq "$PERL_PATH" here.  Other than that, looks
> OK to me.
> 
> Thanks.

Ah, you're right, it needs the quotes. Can this minor changed be fixed by editing the patch or should I re-send it?

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler