Re: [PATCH] test-lib-functions.sh: fix the second argument to some helper functions

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 16, 2015, 20:31 UTC
Message-ID: <xmqq8udrizmk.fsf@gitster.dls.corp.google.com>
In-Reply-To: <vpqoamop28y.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 24 quoted lines

> Elia Pinto <gitter.spiros@gmail.com> writes:
>
>> --- a/t/test-lib-functions.sh
>> +++ b/t/test-lib-functions.sh
>> @@ -478,7 +478,7 @@ test_external_without_stderr () {
>>  test_path_is_file () {
>>  	if ! test -f "$1"
>>  	then
>> -		echo "File $1 doesn't exist. $*"
>> +		echo "File $1 doesn't exist. $2"
>>  		false
>>  	fi
>>  }
>> @@ -486,7 +486,7 @@ test_path_is_file () {
>>  test_path_is_dir () {
>>  	if ! test -d "$1"
>>  	then
>> -		echo "Directory $1 doesn't exist. $*"
>> +		echo "Directory $1 doesn't exist. $2"
>>  		false
>>  	fi
>>  }
>
> Sounds straightforwardly correct to me.

Thanks. This however makes me wonder why you were nominated for reviewing this patch, though...