git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] test-lib-functions.sh: fix the second argument to some helper functions

From
Elia Pinto <gitter.spiros@gmail.com>
Date
Apr 16, 2015, 14:12 UTC
Message-ID
<1429193527-1528-1-git-send-email-gitter.spiros@gmail.com>

The second argument to test_path_is_file and test_path_is_dir must be $2 and not $*, which instead would repeat the file name in the error message.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/test-lib-functions.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index 0698ce7..8f8858a 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -478,7 +478,7 @@ test_external_without_stderr () {
 test_path_is_file () {
 	if ! test -f "$1"
 	then
-		echo "File $1 doesn't exist. $*"
+		echo "File $1 doesn't exist. $2"
 		false
 	fi
 }
@@ -486,7 +486,7 @@ test_path_is_file () {
 test_path_is_dir () {
 	if ! test -d "$1"
 	then
-		echo "Directory $1 doesn't exist. $*"
+		echo "Directory $1 doesn't exist. $2"
 		false
 	fi
 }
-- 
2.1.0
Next: Matthieu Moy
Message 1 of 4 in “test-lib-functions.sh: fix the second argument to some helper functions”
  1. test-lib-functions.sh: fix the second argument to some helper functionsElia Pinto, Apr 16, 2015
  2. Matthieu MoyApr 16, 2015
  3. Junio C HamanoApr 16, 2015
  4. Matthieu MoyApr 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.