Re: [PATCH v3 09/16] index-helper: use watchman to avoid refreshing index with lstat()

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 8, 2016, 06:03 UTC
Message-ID: <xmqq8u0oy6vl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1460074483.5540.9.camel@twopensource.com>

David Turner <dturner@twopensource.com> writes:

Show 19 quoted lines

> On Thu, 2016-04-07 at 15:52 -0700, Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>> > > +		untracked = data + len + 8 + bitmap_size;
>> > 
>> > This breaks compilation as data here is of type (void *).
>> > 
>> > There may be similar breakages in this patch.
>> 
>> It turns out that this is the only one, and
>> 
>> 	untracked = (char *)data + len + 8 + bitmap_size;
>> 
>> is a sufficient fix (I've squashed it in to my copy).
>> 
>> Thanks.
>
> Thanks.  I've squashed it into mine as well but with const char *
> instead (seems maybe cleaner to me)

Yeah, I agree, as "data" is "const void *", so even though the left hand side of the assignment, "untracked", is "const char *", my cast is (temporarily) casting the const away--it would be better to use "const char *" there.

Thanks.