git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 02/16] read-cache: allow to keep mmap'd memory after reading

From
David Turner <dturner@twopensource.com>
Date
Apr 6, 2016, 22:11 UTC
Message-ID
<1459980722-4836-3-git-send-email-dturner@twopensource.com>
In-Reply-To
<1459980722-4836-1-git-send-email-dturner@twopensource.com>
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

Later, we will introduce git index-helper to share this memory with other git processes.

Since the memory will be shared, it will never be unmapped (although the kernel may of course choose to page it out).

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 cache.h      |  3 +++
 read-cache.c | 13 ++++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/cache.h b/cache.h
index b829410..4180e2b 100644
--- a/cache.h
+++ b/cache.h
@@ -333,11 +333,14 @@ struct index_state {
 	struct split_index *split_index;
 	struct cache_time timestamp;
 	unsigned name_hash_initialized : 1,
+		 keep_mmap : 1,
 		 initialized : 1;
 	struct hashmap name_hash;
 	struct hashmap dir_hash;
 	unsigned char sha1[20];
 	struct untracked_cache *untracked;
+	void *mmap;
+	size_t mmap_size;
 };
 
 extern struct index_state the_index;
diff --git a/read-cache.c b/read-cache.c
index 16cc487..7e387e9 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1574,6 +1574,10 @@ int do_read_index(struct index_state *istate, const char *path, int must_exist)
 	mmap = xmmap(NULL, mmap_size, PROT_READ, MAP_PRIVATE, fd, 0);
 	if (mmap == MAP_FAILED)
 		die_errno("unable to map index file");
+	if (istate->keep_mmap) {
+		istate->mmap = mmap;
+		istate->mmap_size = mmap_size;
+	}
 	close(fd);
 
 	hdr = mmap;
@@ -1626,10 +1630,12 @@ int do_read_index(struct index_state *istate, const char *path, int must_exist)
 		src_offset += 8;
 		src_offset += extsize;
 	}
-	munmap(mmap, mmap_size);
+	if (!istate->keep_mmap)
+		munmap(mmap, mmap_size);
 	return istate->cache_nr;
 
 unmap:
+	istate->mmap = NULL;
 	munmap(mmap, mmap_size);
 	die("index file corrupt");
 }
@@ -1655,6 +1661,7 @@ int read_index_from(struct index_state *istate, const char *path)
 		discard_index(split_index->base);
 	else
 		split_index->base = xcalloc(1, sizeof(*split_index->base));
+	split_index->base->keep_mmap = istate->keep_mmap;
 	ret = do_read_index(split_index->base,
 			    git_path("sharedindex.%s",
 				     sha1_to_hex(split_index->base_sha1)), 1);
@@ -1698,6 +1705,10 @@ int discard_index(struct index_state *istate)
 	free(istate->cache);
 	istate->cache = NULL;
 	istate->cache_alloc = 0;
+	if (istate->keep_mmap && istate->mmap) {
+		munmap(istate->mmap, istate->mmap_size);
+		istate->mmap = NULL;
+	}
 	discard_split_index(istate);
 	free_untracked_cache(istate->untracked);
 	istate->untracked = NULL;
-- 
2.4.2.767.g62658d5-twtrsrc
Previous: David TurnerNext: David Turner
Message 3 of 37 in “index-helper, watchman”
  1. 00/16 index-helper, watchmanDavid Turner, Apr 6, 2016
  2. 01/16 read-cache.c: fix constness of verify_hdr()David Turner, Apr 6, 2016
  3. 02/16 read-cache: allow to keep mmap'd memory after readingDavid Turner, Apr 6, 2016
  4. 03/16 index-helper: new daemon for caching index and related stuffDavid Turner, Apr 6, 2016
  5. Johannes SixtApr 7, 2016
  6. Johannes SchindelinApr 7, 2016
  7. David TurnerApr 7, 2016
  8. Johannes SchindelinApr 8, 2016
  9. Duy NguyenApr 8, 2016
  10. David TurnerApr 8, 2016
  11. David TurnerApr 11, 2016
  12. Duy NguyenApr 12, 2016
  13. David TurnerApr 12, 2016
  14. Junio C HamanoApr 12, 2016
  15. David TurnerApr 13, 2016
  16. Duy NguyenApr 14, 2016
  17. Junio C HamanoApr 14, 2016
  18. David TurnerApr 14, 2016
  19. Duy NguyenApr 15, 2016
  20. Junio C HamanoApr 15, 2016
  21. 04/16 index-helper: add --strictDavid Turner, Apr 6, 2016
  22. 05/16 daemonize(): set a flag before exiting the main processDavid Turner, Apr 6, 2016
  23. 06/16 index-helper: add --detachDavid Turner, Apr 6, 2016
  24. 07/16 read-cache: add watchman 'WAMA' extensionDavid Turner, Apr 6, 2016
  25. 08/16 Add watchman support to reduce index refresh costDavid Turner, Apr 6, 2016
  26. 09/16 index-helper: use watchman to avoid refreshing index with lstat()David Turner, Apr 6, 2016
  27. Junio C HamanoApr 7, 2016
  28. Junio C HamanoApr 7, 2016
  29. David TurnerApr 8, 2016
  30. Junio C HamanoApr 8, 2016
  31. 10/16 update-index: enable/disable watchman supportDavid Turner, Apr 6, 2016
  32. 11/16 unpack-trees: preserve index extensionsDavid Turner, Apr 6, 2016
  33. 12/16 index-helper: kill modeDavid Turner, Apr 6, 2016
  34. 13/16 index-helper: don't run if already runningDavid Turner, Apr 6, 2016
  35. 14/16 index-helper: autorun modeDavid Turner, Apr 6, 2016
  36. 15/16 index-helper: optionally automatically runDavid Turner, Apr 6, 2016
  37. 16/16 read-cache: config for waiting for index-helperDavid Turner, Apr 6, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.