Re: [RFC/PATCH 0/2] place cherry pick line below commit title

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 3, 2016, 22:13 UTC
Message-ID: <xmqq8tu55bel.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <d3df0636-1975-1d08-2f34-384984c72e5d@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 6 quoted lines

> There are other options like checking for indentation or checking for
> balanced parentheses/brackets, but I think that these would lead to
> surprising behavior for the user (this would mean that whitespace or
> certain characters could turn a valid trailer into an invalid one or
> vice versa, or change the behavior of trailer.ifexists, especially
> "replace").

Yes, that is exactly why I said that it may be necessary for the code to analize the lines in a block identified as "likely to be a trailing block" more carefully. We can afford to be loose as long as the only allowed operation is to append one at the end, but once we start removing/replacing an existing entry, etc., the definition of what an entry is becomes very much relevant.