Re: [PATCHv2] attr: convert to new threadsafe API
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 12, 2016, 21:38 UTC
- Message-ID
- <xmqq8ttt2qpp.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <44c554b8-7ac1-047d-59f0-b4d5331ed496@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
> Sigh. DCLP, the Double Checked Locking Pattern. ... > I suggest you go without it, then measure, and only *then* optimize if > it is a bottleneck.
That comes from me in earlier discussion before the patch, namely in <xmqqeg3m8y6y.fsf@gitster.mtv.corp.google.com>, where I wondered if a cheap check outside the lock may be a possible optimization opportunity, as this is a classic singleton that will not be deinitialized, and once the codepath gets exercised, we would be taking the "nothing to do" route 100% of the time.