Re: [PATCHv2] attr: convert to new threadsafe API

From: Stefan Beller <sbeller@google.com>
Date: Oct 12, 2016, 21:39 UTC
Message-ID: <CAGZ79kaQGs_3dhd-yEzaq=CRXGQhbMuN_7FdFY=FeKZ4scmMeQ@mail.gmail.com>
In-Reply-To: <xmqqh98h2r5t.fsf@gitster.mtv.corp.google.com>

On Wed, Oct 12, 2016 at 2:28 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> This version adds the actual thread safety,
>> that is promised in the documentation, however it doesn't add any optimization,
>> i.e. it's a single global lock. But as we do not expect contention, that is fine.
>
> Because we have to start _somewhere_, I agree it is a good approach
> to first try the simplest implementation and then optimize later,
> but is it an agreed consensus that we do not expect contention?
>

I agree on that. Did you mean this is obvious to the reader? I just wanted to state how I'll do it, such that if in the future someone digs up this code, they'll know I did not look at performance in the first run.