git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] allow checkout and branch to create branches on a merge base

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 27, 2019, 00:01 UTC
Message-ID
<xmqq8svwtixi.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190426235220.GB28055@dev-l>
Denton Liu <liu.denton@gmail.com> writes:
Show 6 quoted lines
> Out of respect for your time as the maintainer (since you have a lot of
> topics to deal with), how do you prefer small fixups be submitted?
>
> * A complete reroll of the whole series
> * A replacement for one patch in the series
> * A follow-up email with an "oops, please change x to y"

Depends on how small your "small" is, but in general, the above is a good approximation of the preference order.

Wholesale replacement without having to think is the easiest. When the latest round is not from a distant past (i.e. less than two weeks old), replacement patches for only selected steps is also fine, as I can pretend it is a wholesale replacement by completing the missing patches by picking them from the mailbox while using the updated ones.

"Please change x to y" is the least welcome, with a big exception that it is the easiest when it is a change to a few words in a single place, either in the log message or a file contents, of a single patch topic---in other words, something I can deal with "commit --amend" and needs less than 2 minutes to handle. Anything larger than that size and requires me to fire up "rebase -i" starts to make me wonder why _I_ am doing that, not the topic owner.

Thanks.
Previous: Denton LiuNext: Denton Liu
Message 18 of 21 in “checkout: allow -b/-B to work on a merge base”
  1. 0/3 checkout: allow -b/-B to work on a merge baseDenton Liu, Apr 25, 2019
  2. 1/3 t2018: cleanup in current testDenton Liu, Apr 25, 2019
  3. Eric SunshineApr 25, 2019
  4. Denton LiuApr 26, 2019
  5. Junio C HamanoApr 26, 2019
  6. Eric SunshineApr 26, 2019
  7. 2/3 t2018: demonstrate checkout -b merge base bugDenton Liu, Apr 25, 2019
  8. 3/3 checkout: allow -b/-B to work on a merge baseDenton Liu, Apr 25, 2019
  9. Junio C HamanoApr 26, 2019
  10. Junio C HamanoApr 26, 2019
  11. 0/3 allow checkout and branch to create branches on a merge baseDenton Liu, Apr 26, 2019
  12. 1/3 t2018: cleanup in current testDenton Liu, Apr 26, 2019
  13. 2/3 t2018: demonstrate checkout -b merge base bugDenton Liu, Apr 26, 2019
  14. 3/3 branch: make create_branch accept a merge base revDenton Liu, Apr 26, 2019
  15. Junio C HamanoApr 26, 2019
  16. Denton LiuApr 26, 2019
  17. Denton LiuApr 26, 2019
  18. Junio C HamanoApr 27, 2019
  19. 0/2 allow checkout and branch to create branches on a merge baseDenton Liu, Apr 27, 2019
  20. 1/2 t2018: cleanup in current testDenton Liu, Apr 27, 2019
  21. 2/2 branch: make create_branch accept a merge base revDenton Liu, Apr 27, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.