Re: [PATCH 2/2] stash: remove the stash.useBuiltin setting

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 3, 2020, 16:47 UTC
Message-ID: <xmqq8skh9yhj.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.2003031430180.46@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 15 quoted lines

>>  	prefix = setup_git_directory();
>>  	trace_repo_setup(prefix);
>>  	setup_work_tree();
>
> However, this is only needed because we did not change `git.c` at the same
> time (as I had done for `rebase` in 80dfc9242eb (git: mark cmd_rebase as
> requiring a worktree, 2019-07-24)). In other words, I think we will also
> want to address this part of `git.c`:
>
>         /*
>          * NEEDSWORK: Until the builtin stash is thoroughly robust and no
>          * longer needs redirection to the stash shell script this is kept as
>          * is, then should be changed to RUN_SETUP | NEED_WORK_TREE
>          */
>         { "stash", cmd_stash },

Ah, I missed that part; thanks for chiming in.