Re: Git Rebase: test failing with GIT_TEST_STASH_USE_BUILTIN=false

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 25, 2020, 16:57 UTC
Message-ID: <xmqq36ayob9a.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <61922A39-13DC-4B17-94FC-7F67DF308347@booking.com>

Son Luong Ngoc <son.luong@booking.com> writes:

Show 9 quoted lines

> I have been trying to build git from source and noticing that some
> tests have been failing since 2.25 with the flag
> "GIT_TEST_STASH_USE_BUILTIN=false"
>
> I think in 2.25 t3903.103 started to fail (rebase related) and
> current master t3904 may be failing also.
>
> Is "GIT_TEST_STASH_USE_BUILTIN=false" is still being tested with
> or are we totally deprecating this flag?

In the longer term, when "git stash" gains new features that did not exist in the original scripted version, tests that observe how these features work would start failing when using the scripted version.

I picked some people from "git shortlog --no-merges builtin/stash.c" and placed them on the CC line---perhaps they may know more. It happens that Johannes is also familiar with "rebase", which you said is involved in the test failure, so I'd imagine he would be the best person to ask.

Thanks for a report.