git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ci: avoid using the deprecated `set-env` construct

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 17, 2020, 20:14 UTC
Message-ID
<xmqq8saz68ro.fsf@gitster.c.googlers.com>
In-Reply-To
<nycvar.QRO.7.76.6.2011171620180.18437@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 5 quoted lines
>> Perhaps like the following (which is copied-and-pasted without
>> understanding what is going on or without doing nothing more than
>> skimming [*1*])?
>
> Yes, of course, this precisely what we need.
Thanks.
--- >8 ------ >8 ------ >8 --- cut here --- >8 ------ >8 ------ >8 ---
Subject: [PATCH] ci: avoid `set-env` construct in print-test-failures.sh

Imitating cac42e47 (ci: avoid using the deprecated `set-env` construct, 2020-11-07), avoid deprecated ::set-env and use the recommended alternative instead in print-test-failures.sh

Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 ci/print-test-failures.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ci/print-test-failures.sh b/ci/print-test-failures.sh
index 92a983a265..c70d6cdbf2 100755
--- a/ci/print-test-failures.sh
+++ b/ci/print-test-failures.sh
@@ -48,7 +48,7 @@ do
 			;;
 		github-actions)
 			mkdir -p failed-test-artifacts
-			echo "::set-env name=FAILED_TEST_ARTIFACTS::t/failed-test-artifacts"
+			echo "FAILED_TEST_ARTIFACTS=t/failed-test-artifacts" >>$GITHUB_ENV
 			cp "${TEST_EXIT%.exit}.out" failed-test-artifacts/
 			tar czf failed-test-artifacts/"$test_name".trash.tar.gz "$trash_dir"
 			continue
-- 
2.29.2-458-g8cf0a80384
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 5 of 6 in “ci: avoid using the deprecated `set-env` construct”
  1. ci: avoid using the deprecated `set-env` constructJohannes Schindelin via GitGitGadget, Nov 7, 2020
  2. Chris WebsterNov 7, 2020
  3. Junio C HamanoNov 17, 2020
  4. Johannes SchindelinNov 17, 2020
  5. Junio C HamanoNov 17, 2020
  6. Johannes SchindelinNov 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.