Re: [PATCH] ci: avoid using the deprecated `set-env` construct

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 18, 2020, 11:48 UTC
Message-ID: <nycvar.QRO.7.76.6.2011181248320.56@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqq8saz68ro.fsf@gitster.c.googlers.com>

Hi Junio,

On Tue, 17 Nov 2020, Junio C Hamano wrote:

Show 20 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> Perhaps like the following (which is copied-and-pasted without
> >> understanding what is going on or without doing nothing more than
> >> skimming [*1*])?
> >
> > Yes, of course, this precisely what we need.
>
> Thanks.
>
> --- >8 ------ >8 ------ >8 --- cut here --- >8 ------ >8 ------ >8 ---
>
> Subject: [PATCH] ci: avoid `set-env` construct in print-test-failures.sh
>
> Imitating cac42e47 (ci: avoid using the deprecated `set-env`
> construct, 2020-11-07), avoid deprecated ::set-env and use the
> recommended alternative instead in print-test-failures.sh
>
> Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Thank you so much for tying up this loose end, Dscho

Show 21 quoted lines

> ---
>  ci/print-test-failures.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ci/print-test-failures.sh b/ci/print-test-failures.sh
> index 92a983a265..c70d6cdbf2 100755
> --- a/ci/print-test-failures.sh
> +++ b/ci/print-test-failures.sh
> @@ -48,7 +48,7 @@ do
>  			;;
>  		github-actions)
>  			mkdir -p failed-test-artifacts
> -			echo "::set-env name=FAILED_TEST_ARTIFACTS::t/failed-test-artifacts"
> +			echo "FAILED_TEST_ARTIFACTS=t/failed-test-artifacts" >>$GITHUB_ENV
>  			cp "${TEST_EXIT%.exit}.out" failed-test-artifacts/
>  			tar czf failed-test-artifacts/"$test_name".trash.tar.gz "$trash_dir"
>  			continue
> --
> 2.29.2-458-g8cf0a80384
>
>