Re: [PATCH v2 4/5] mailmap: use case-sensitive comparisons for local-parts and names

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2021, 00:46 UTC
Message-ID: <xmqq8s96yjs7.fsf@gitster.c.googlers.com>
In-Reply-To: <87czykvg19.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 18 quoted lines

> On Sun, Jan 03 2021, brian m. carlson wrote:
>
> We just have to worry about cases where you're not all of these people
> in one project's commit metadata and/or .mailmap, and thus mailmap rules
> would match too generously:
>
>     "brian m. carlson" <sandals@crustytoothpaste.net>
>     "brian m. carlson" <SANDALS@crustytoothpaste.net>
>     "BRIAN M. CARLSON" <sandals@crustytoothpaste.net>
>     "BRIAN M. CARLSON" <SANDALS@crustytoothpaste.net>
>
> Is that really plausible? In any case, neither of these two patches make
> reference to us already having changed this in the past in 1.6.2 and &
> there being reports on the ML about the bug & us changing it back. See
> https://lore.kernel.org/git/f182fb1700e8dea15459fd02ced2a6e5797bec99.1238458535u.git.johannes.schindelin@gmx.de/
>
> Maybe we should still do this, but I think for a v3 it makes sense to
> summarize that discussion etc.

After reading the old discussion again, I am not sure if this is worth doing. To many people, it is a promise we've made and kept that we treat addresses including the local part case-insensitively when summarising commits by ident strings.

I'd really wish that this series were structured to have 5/5 early and 3&4/5 squashed into a single final patch.