Re: [PATCH v2 5/5] mailmap: support hashed entries in mailmaps
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Jan 6, 2021, 00:28 UTC
- Message-ID
- <X/UENS0EXyFjjjHA@camp.crustytoothpaste.net>
- In-Reply-To
- <xmqqft3fywsd.fsf@gitster.c.googlers.com>
On 2021-01-05 at 20:05:22, Junio C Hamano wrote:
Show 18 quoted lines
> "brian m. carlson" <sandals@crustytoothpaste.net> writes: > > > For example, a person may transition from one gender to another, > > changing their name, or they may have changed their name to disassociate > > themselves from an abusive family or partner. In such a case, using the > > former name or address in any way may be undesirable and the person may > > wish to replace it as completely as possible. > > I am not sure if we want to even mention the "for example" here. > > These are certainly all legitimate reasons to want this feature, but > after reading the "for example", lack of a corresponding negative > statement (e.g. sometimes people also change their name or address > to hide their bad behaviour in the past that is associated with > these names) needlessly stood out and made me wonder if we need to > somehow defend the feature with "...but we do not mean to abet > people in hiding their past bad behaviour with this mechanism". I'd > prefer us not forced to defend the mechanism if we did not have to.
I added it because I imagine the use cases for this feature aren't immediately obvious to a lot of people and the general rule is that commit messages explain why we would implement such a feature. If you'd prefer I drop it and leave it up to the imagination (or to the list archives), I can do that.
Show 7 quoted lines
> > +SHA-1 is not accepted as a hash algorithm in mailmaps. > > Is this needed to be said? After all, we won't take @md5: or > @blake2: or anything other than @sha256: in this version (and > probably any forseeable versions). Unless we offer a way to plug-in > algos of projects' choice, that is, and at that point, "SHA-1 is not > accepted" is a statement too strong for us to make.
I'll drop that line.
-- brian m. carlson (he/him or they/them) Houston, Texas, US