Re: Cc'ing the Git maintainer on GitGitGadget contributions, was Re: [PATCH 0/1] add--interactive: skip index refresh in reset patch mode

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 10, 2021, 20:18 UTC
Message-ID: <xmqq8s90a6li.fsf@gitster.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.2101101306310.56@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 12 quoted lines

> Hi Taylor,
>
> On Fri, 8 Jan 2021, Taylor Blau wrote:
> ...
>> I think that this could be reasonably addressed. When someone opens a PR
>> (but before the hit /submit), GGG could say:
>>
>>     Your change touches these files, and so suggested reviewers include
>>     X, Y, Z. When you believe your submission is in its last round,
>>     please also include the maintainer, M.
>
> That is an option.

As Taylor created the above suggestion as a counter-proposal, I can see that I apparently did not express what I meant very well, when I said:

    Is there a point in the end-user experience flow, starting at
    the time when they push their proposed change to their
    repository, throw a pull request at GitHub, say "/submit", and
    then GGG finally sends out a patch e-mail, where the GGG
    machinery can inspect the change and give the user (preferrably
    before the user says /submit) a hint that says "you may want to
    add Cc: to these people in such and such case, and if you think
    the situation falls into these cases, tell me so by saying
    /submit-with-suggested-cc instead of the usual /submit"?

What Taylor suggested, and what you seem to be agreeing to, is exactly what I had in mind when I wrote the above in my message.

So perhaps we three are on the same page from the beginning ;-)

Looking forward to see a new feature that helps contributors to more easily ask help from appropriate people.

Thanks.